Skip to content

Chore/fx e2e test updates #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 31, 2025
Merged

Chore/fx e2e test updates #2368

merged 20 commits into from
Mar 31, 2025

Conversation

umarkayani-adaptive
Copy link
Contributor

No description provided.

algreasley
algreasley previously requested changes Mar 20, 2025
View reviewed changes
@algreasley algreasley force-pushed the chore/fx-e2e-test-updates branch 2 times, most recently from df41f07 to 6d75052 Compare March 26, 2025 20:23
@umarkayani-adaptive umarkayani-adaptive marked this pull request as ready for review March 27, 2025 13:11
@github-actions GitHub Actions
Copy link

(auto-deploy) A deployment has been created for this Pull Request

Preview links

As part of the code review process, please ensure that you test against the following

Version URL
Web https://web.env.reactivetrader.com/pull/2368
OpenFin - FX fins://openfin.env.reactivetrader.com/pull/2368/config/rt-fx.json
OpenFin - Credit fins://openfin.env.reactivetrader.com/pull/2368/config/rt-credit.json
OpenFin - Launcher fins://openfin.env.reactivetrader.com/pull/2368/config/launcher.json
OpenFin - Workspace fins://openfin.env.reactivetrader.com/pull/2368/workspace/config/workspace.json

Performance

Please ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+.

https://developers.google.com/speed/pagespeed/insights/?url=https://web.env.reactivetrader.com/pull/2368

umarkayani-adaptive and others added 18 commits March 31, 2025 11:47
@umarkayani-adaptive @SHolleworth
Initial update of fx-spot tile tests using POs
13a19df 
* updated fixtures to use new POs
* added POs for NewRFQ page and BlotterPage
* moved some timeouts into utils
@umarkayani-adaptive @SHolleworth
fixed formatting and linting issues
a201abc
@umarkayani-adaptive @SHolleworth
Addressed PR comments
a2b3a88 
* renamed PO file
* moved getters to top of PO file
* cleaned up POs - removed async/awaits
@algreasley @SHolleworth
alan mods to get blotter spec running (incomplete)
92dc7bf
@umarkayani-adaptive @SHolleworth
Updated POs and added FxAnalyticsPO
2532e50 
* updated fixtures to reflect new page additions
* updated some tests with POs
@algreasley @SHolleworth
chore: fix openfin popout tests
8a08ce6
@algreasley @SHolleworth
chore: fix limit checker E2E tests
ac0bf92
@algreasley @SHolleworth
chore: clean up analytics and credit E2E specs
4ffffa1
@algreasley @SHolleworth
chore: add LC PO and update LC E2E tests
84584cc
@umarkayani-adaptive @SHolleworth
Updated fx-spot-tile tests with POs
218ddb8
@umarkayani-adaptive @SHolleworth
Updated with missed .page replaces with POs
0035e94
@umarkayani-adaptive @SHolleworth
fixed formatting
59a66da
@umarkayani-adaptive @SHolleworth
fix: removed unneeded POs and updated naming
4b09f24
@umarkayani-adaptive @SHolleworth
fix: added setViewport for Openfin on FxTile
846a1f9
@SHolleworth
fix: fx-blotter afterall
1c54732
@SHolleworth
fix: resize correct window
b54b7c8
@SHolleworth
chore: clearFilter reverted to single click
37856f6
@SHolleworth
chore: move clearFilter out of afterall
db29ae7
@SHolleworth SHolleworth force-pushed the chore/fx-e2e-test-updates branch from fe3ac62 to db29ae7 Compare March 31, 2025 11:14
@algreasley algreasley dismissed their stale review March 31, 2025 13:13

code changes have resolved

@SHolleworth SHolleworth merged commit 8e26ee0 into master Mar 31, 2025
6 checks passed
@SHolleworth SHolleworth deleted the chore/fx-e2e-test-updates branch March 31, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algreasley algreasley algreasley left review comments

@SHolleworth SHolleworth SHolleworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umarkayani-adaptive @algreasley @SHolleworth